Fixing CompareToInstance & CompareToSet extension methods to account for field on a given type #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted StepArgumentTypeConverter into a chain of responsibility delegating the conversion logic to: - IdentityConverter which returns the untouched value if it can be assigned to a variable of the target type (logic comes from StepDefinitionMatchService and TestExecutionEngine) - StepArgumentTransformationConverter which tries to perform the conversion using user defined step argument transformations - SimpleConverter which handle the simple conversions: enums, GUID and whatever is supported by System.Convert.ChangeType
Fixed bug causing StepArgumentTransformation regex to be bypassed when argument is not a string. Added check for StepArgumentTransformation to have one and only one parameter when no regex is defined.
Sames behaviour as in SpecFlow Assist namespace
Added support for table conversion directly in StepArgumentTypeConverter.
If HorizontalTableConvert can't find a conversion from a vertical table to the target item type, and the vertical table only has one property, it will try to find a converter for the string value of this property.
VerticalTableConverter will use the constructor that includes the maximum number of columns with no matching writable property. Columns with no matching constructor parameter or writer property are ignored.
Fixed issues in Invalid handling of empty strings in tables when converting to nullable enum types
This reverts commit 014320d.
… exceptions properly). This required an upgrade to .NET 4 in TechTalk.SpecFlow.csproj
…areToProjectionOfInstance.
Add German "Gegeben seien" ;)
Updated Australian English as per cucumber/gherkin#196
Updated TableHelperExtensionMethods.FillInstance() to populate fields in addition to properties
… create each instance.
New Features: + Specflow Test execution report derived through MSTest or NUnit displays the tags attached with each scenario or feature in a seperate column viz. "Category" + Minor fix for a toggle functionality in the XSLT file to make it work consistently with IE and Chrome. New Features: + Specflow Test execution report derived through MSTest or NUnit displays the tags attached with each scenario or feature in a seperate column viz. "Category" + Minor fix for a toggle functionality in the XSLT file to make it work consistently with IE and Chrome.
This reverts commit f60e5d4.
Added "nunit:category" node for representing tags when MSTest Report(trx) is used for generating the Specflow report.
Inclusion of two new replacements in field mapping for hyphen and question mark
Inclusion of two new replacements in field mapping for hyphen and question mark
Add overload to Assist's CreateSet<T> accepting Func<TableRow,T>
Added Table extension methods CompareToProjectionOfSet/Instance (issue 290)
Table conversion in StepArgumentTypeConverter
Add description to testOutput parameter of nunitexecutionreport
Update Languages.xml
Updated Australian English
Nullable enum fix
Async/Await support for Specflow Steps
Specflow Execution Report - Changes to MsTestToNunit.xslt file to add "Tags" as Categories in the NUnit Report
Made the link label anchor bottom | right to follow the rest of the controls.
#328 Anchored the link label correctly
… as well as fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently ran into a issue with specflow.assist's compareToInstance and compareToSet extension methods are not accounting for fields on a given type (instead they are accounting for only properties on a given type).
This pull request includes fixes for these issues and unit tests around the same.
Reviewer: Joseph Buschmann