Open
Conversation
Created new event card with like/dislike button
Added GET/POST reaction routes
Changed userId property to userEmail
Added userEmail and eventId props to ThumbButtons
Connected ThumbButtons with backend
nikhilitis
requested changes
Feb 5, 2025
Collaborator
nikhilitis
left a comment
nikhilitis
left a comment
There was a problem hiding this comment.
This looks great for the most part! The code is readable, functions correctly on the website, and is easy to follow.
Just one comment:
When I run the site on your branch, I get the following output on stdout for the backend:
ValidationError: Reactions validation failed: reactionType: Path `reactionType` is required.
at model.Document.invalidate (/Users/nikhilrao/cses/cses_webdev/backend/node_modules/mongoose/lib/document.js:3157:32)
at /Users/nikhilrao/cses/cses_webdev/backend/node_modules/mongoose/lib/document.js:2950:17
at /Users/nikhilrao/cses/cses_webdev/backend/node_modules/mongoose/lib/schematype.js:1368:9
at processTicksAndRejections (node:internal/process/task_queues:78:11)
I'm not sure what specific action is triggering this, but it would be nice to have it fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created an event card with thumb- up/down buttons. Also added a new collection to the database for storing event reaction data.