changed the username from random to the google profile name#75
Open
RamonsArchive wants to merge 8 commits intomainfrom
Open
changed the username from random to the google profile name#75RamonsArchive wants to merge 8 commits intomainfrom
RamonsArchive wants to merge 8 commits intomainfrom
Conversation
…to toggle between Pie and AreaGraph. Also imporved styling of Total spending section making height dynamic to its contents and established frontend types in new folder utisl
RamonsArchive
requested review from
VedVar43789,
anikadontu and
shree-venkatesh
Collaborator
|
Im not a part of CSES anymore, but its good to see that you have started on development 👍🏼 |
himansig7
requested changes
Jan 26, 2026
Collaborator
himansig7
left a comment
himansig7
left a comment
There was a problem hiding this comment.
The actual PR seems to go through smoothly. However, I need to see if tested with multiple days to see what the area chart looks like over a multi-day period. Please show this test case and make a PR with a screenshot of what that would look like.
On my end, the username change also seems to just have the random name, not a google profile name. In the updated PR I would like this to be double checked and also have screenshots attached for how everything should look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What changes did you make? Include screenshots if applicable, or explain how to view the changes.
Testing
How did you confirm your changes work? (Automated tests, manual verification, etc.)
Tracking
Add your issue number below.
Resolves #