finishes search feature with multiple filters and sorting#96
Open
taha-qam wants to merge 2 commits intoCSES-Open-Source:devfrom
Open
finishes search feature with multiple filters and sorting#96taha-qam wants to merge 2 commits intoCSES-Open-Source:devfrom
taha-qam wants to merge 2 commits intoCSES-Open-Source:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
I ran the code and tested search options, filters myself with products. To make sure it would work with Abas's code, I copied his changed files into my code, and made any changes needed in my code to have it work with his. From what I have seen my filtering/sorting logic works with his frontend
Tracking
Build feature for searching products by name, category, and price #64