Open
Conversation
…nter into feature/search
chase-of-the-fjords
requested changes
May 7, 2025
Collaborator
chase-of-the-fjords
left a comment
chase-of-the-fjords
left a comment
There was a problem hiding this comment.
This looks basically perfect, the only change I'd make is that right now the filter starts open by default. I'd change it to have the filter closed until you click the filter button. Otherwise I'm ready to approve!
Collaborator
|
Looks like there are new merge conflicts, but I'll re-review the PR once they're fixed. |
chase-of-the-fjords
requested changes
May 16, 2025
Collaborator
chase-of-the-fjords
left a comment
chase-of-the-fjords
left a comment
There was a problem hiding this comment.
This looks great! There are a few issues that I also mentioned in the order-results PR - might be best to fix those issues here and then merge into the order-results branch. Otherwise this should be ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
manually verified that the filters were displaying the correct products
manually verified that the product tags were being saved to the database
Tracking
Resolves #64