Open
Conversation
arnavjk007
reviewed
Feb 5, 2026
models/Listing.ts
Outdated
| { | ||
| itemId: 1, | ||
| labId: 1, | ||
| createdAt: 1, // ask if there can be multiple listings on same item in same lab but different time |
Collaborator
There was a problem hiding this comment.
Yes we will probably have same item listings at different times as they could be same item but a different/older version.
arnavjk007
requested changes
Feb 5, 2026
Collaborator
arnavjk007
left a comment
There was a problem hiding this comment.
We can remove the images field in the schema since we aren't implementing that until V2, and it may be too complicated to implement, so it's a feature we are on the fence about.
models/Listing.ts
Outdated
| itemId: { type: String, required: true }, | ||
| labId: { type: String, required: true }, | ||
| quantityAvailable: { type: Number, required: true }, | ||
| images: { type: [String], required: false }, |
Collaborator
There was a problem hiding this comment.
I think for now we can leave images out of the schema since it is a V2 feature.
Collaborator
Author
|
I've pushed the requested change @arnavjk007 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
[ Couple of bullet points ]
I would like some feedback though if this is how listing data is to be expected. For example, I was wondering if all fields are required, or maybe images are optional. Also I created a compound index for uniquely identifying certain listings. Would people be able to create multiple listings on same item in same lab but at different times?
Issue ticket number and link
[ Insert Link & Ticket #] <- not sure
Checklist before requesting a review