Skip to content

Conversation

@ryanmrichard
Copy link
Contributor

Is this pull request associated with an issue(s)?
Sort of related to #122, but does not fix it.

Description
To implicitly discourage people from using CMAKETEST_TEST when a test should fail the example falls back to using the name of the function. I want to stop short of telling people not to use it in case we don't actually need to deprecate it.

TODOs
R2g.

@ryanmrichard ryanmrichard requested a review from zachcran July 8, 2025 17:51
@ryanmrichard ryanmrichard self-assigned this Jul 8, 2025
@ryanmrichard
Copy link
Contributor Author

As was just pointed out to me in #122, using CMAKETEST_TEST is the non-deprecated interface so we need to fix it.

@zachcran
Copy link
Contributor

zachcran commented Jul 8, 2025

@ryanmrichard I didn't realize that using the function names was deprecated. The inverse of this PR would be useful to warn about the deprecation. I don't know about the other repos, but CMaize will definitely need to be switched over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants