Clarify username taken error message during registration#69
Open
belugaaaaaaaa wants to merge 2 commits intoCMU-313:mainfrom
Open
Clarify username taken error message during registration#69belugaaaaaaaa wants to merge 2 commits intoCMU-313:mainfrom
belugaaaaaaaa wants to merge 2 commits intoCMU-313:mainfrom
Conversation
Pull Request Test Coverage Report for Build 21612115417Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the error message displayed during user registration when a selected username conflicts with an existing user or group name.
Previously, the client-side validation showed a generic “username taken” message, which did not clearly indicate that group name conflicts are also checked during registration. This could lead to user confusion when a username was unavailable for reasons other than an existing user account.
Changes
Updated public/src/client/register.js to use a more precise translation key when a username or group name conflict is detected during registration.
Added a corresponding error message entry in public/language/en-US/error.json to clearly communicate the cause of the conflict to the user.
Imapact
This change improves the accuracy of user-facing feedback during registration without altering backend logic. By making the error message more explicit, it reduces ambiguity and helps users better understand why a chosen username cannot be used.