Implemented suggested username feature with suffix "suffix"#49
Open
eseudieu wants to merge 1 commit intoCMU-313:mainfrom
Open
Implemented suggested username feature with suffix "suffix"#49eseudieu wants to merge 1 commit intoCMU-313:mainfrom
eseudieu wants to merge 1 commit intoCMU-313:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodebb as currently implemented is capable of telling registrants when their desired username is not available; however, it does not offer any alternative names as one might desire from a registration system.
The change that will be described has added this functionality to where a custom suffix is added to the registrants desired username in hopes of generating an available, similar name.
Below is the displayed UI when attempting to register with a username that has already been taken.
Two meaningful changes were made to the codebase in this branch. First, the "username-taken" key in public/language/en-US/error.json had its value adapted to display an argument (the alternative username). Then, the validateUsername() function in public/src/client/register.js was changed so that the function to display an error when attempting to register with a used username took in an alternative username as an argument.
This pull request closes #1.