fixed bug where multiple metaboxes caused search modal to send posts …#41
Open
cggit wants to merge 1 commit intoCMB2:masterfrom
Open
fixed bug where multiple metaboxes caused search modal to send posts …#41cggit wants to merge 1 commit intoCMB2:masterfrom
cggit wants to merge 1 commit intoCMB2:masterfrom
Conversation
…to the wrong metabox
|
I tested this today and it fixes the issues in my testing. My testing environment has:
One nitpicky thing, when you open a search and type a search term it is preserved if you open the search for a separate instance of the field. Can that field be cleared when the modal is opened? Or stay specific to the field that the search occured for? |
desrosj
reviewed
Oct 16, 2017
| var $wrap = $this.closest(' .attached-posts-wrap' ); | ||
| app.$.retrievedPosts = $wrap.find( '.retrieved' ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to the wrong metabox
Counts number of attached-posts instances on the page and if finds more than one sets context when clicking the extra search button