Fix main class, allows loading on options pages#30
Open
JayWood wants to merge 1 commit intoCMB2:masterfrom
Open
Fix main class, allows loading on options pages#30JayWood wants to merge 1 commit intoCMB2:masterfrom
JayWood wants to merge 1 commit intoCMB2:masterfrom
Conversation
Member
|
This will completely break the loader functionality as you are not actually using the You'd be better off using the newer loader that I have in the wds-shortcodes plugin: https://github.com/WebDevStudios/WDS-Shortcodes/blob/master/wds-shortcodes.php#L112-L118 It hooks into the first available hook, depending on when the file is loaded, which is what you're looking for. |
Author
|
@jtsternberg awesome, thanks for the info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much a rewrite of the main initializing class. Used CMB2 as a staple for this sort of thing. The previous main class wouldn't allow us to use the plugin on an options page. It now does.
cmb2_init, notafter_setup_theme@jtsternberg I know you originally had a hand in here, so if you get time to review that'd be amazing.