Fix: Use "Roger" instead of "Roger that" per British Army Voice Procedure#95
Merged
CJFWeatherhead merged 2 commits intomainfrom Oct 31, 2025
Merged
Conversation
Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix British Army voice procedure affirmation usage
Fix: Use "Roger" instead of "Roger that" per British Army Voice Procedure
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates a bot response message to adhere to proper military radio protocol. The change modifies the task start confirmation from "Roger that!" to "Roger!" across the codebase.
- Changed "Roger that!" to "Roger!" in task start messages to follow British Army Voice Procedure
- Updated both the example configuration file and the actual message constants
- Added CHANGELOG entry documenting the change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| messages.json.example | Updated task_start message template to use "Roger!" |
| chatrixcd/messages.py | Updated DEFAULT_MESSAGES constant with "Roger!" |
| CHANGELOG.md | Documented the message protocol correction |
CJFWeatherhead
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
British Army Voice Procedure uses "Roger" as a single-word affirmative reply. "Roger that" is a Hollywood-ism, not proper military protocol.
Changes
Example
The bot now uses authentic military voice procedure while maintaining its personality.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.