Skip to content

fix(redirector): trigger login if PermissionDenied is raised for unau… #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzacharo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(redirector): trigger login if PermissionDenied is raised for unau… #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions site/cds_rdm/legacy/redirector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
request,
url_for,
)
from flask_login import current_user
from invenio_base import invenio_url_for
from invenio_communities.views.ui import not_found_error
from invenio_records_resources.services.errors import PermissionDeniedError
Expand Down Expand Up @@ -71,11 +72,16 @@ def legacy_files_redirect(legacy_id, filename):
all_versions = get_record_versions(record["id"])
for version in sorted(all_versions.keys(), reverse=True):
record_version = all_versions[version]
if filename in record_version["files"]["entries"]:
# Public records with restricted files do not serialize entries
record_version_files = record_version["files"].get("entries", [])
if filename in record_version_files:
record = record_version
break
except PermissionDeniedError:
return abort(403)
if not current_user.is_authenticated:
# trigger the flask-login unauthorized handler
return current_app.login_manager.unauthorized()
return render_template(current_app.config["THEME_403_TEMPLATE"]), 403

file_path = Path(filename)
filename_ext = file_path.suffix[1:].lower() if file_path.suffix else ""
Expand Down