Draft
Conversation
added 2 commits
February 5, 2024 19:15
Added a registry and Enum of all models to the LlavaMetaModel. All subclass config model type name is saved in the base class. Added additional param for llm_type in train and builder scripts, as well is in most calls of "load_pretrained_model()"
Now the name is the class name and value is the config shorthand
PrateekHumane
force-pushed
the
feature/model-type-argument
branch
from
52399ed to
a217dce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an argument llm_type to choose the llm model class that will be used in both training and inference.
The valid values for llm_type are taken from the existing 'model_type' variable from the corresponding models config class. More specifically the choices are:
['llava', 'llava_mistral','llava_neox']When adding a new llm class, as long as the class is defined, the method init_subclass will be invoked in the LlavaMetaModel base class and the Enum class variable ModelType will automatically be updated.