Use NINT() instead of INT() in chkgrid.f origin checking#138
Open
roarkmd wants to merge 1 commit intoCEMPD:masterfrom
Open
Use NINT() instead of INT() in chkgrid.f origin checking#138roarkmd wants to merge 1 commit intoCEMPD:masterfrom
roarkmd wants to merge 1 commit intoCEMPD:masterfrom
Conversation
…to prevent failure for cases where CHK_X/CHK_Y is a float slighly below the value of the rounded-up integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed chkgrid.f check origin test to use NINT(), instead of INT(), to prevent failure for cases where CHK_X/CHK_Y is a float slightly below the value of the next rounded-up integer.
Consider this case that will currently fail:
X0 = 996000
Y0 = 256000
XORIG = 408000.
YORIG = -216000.
XCELL = 1333.33337
YCELL = 1333.33337
(Note, I am aware that the grid resolution is probably considered unusual.)