Skip to content

Genbank fix#357

Merged
jessicarowell merged 11 commits intodevfrom
genbank-fix
Sep 20, 2025
Merged

Genbank fix#357
jessicarowell merged 11 commits intodevfrom
genbank-fix

Conversation

@jessicarowell
Copy link
Collaborator

Description

Fixes to the genbank workflow

These do not include checks to the sqn file format. I suspect more tweaking is needed there.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • [N/A] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [N/A] Did you check for sensitive data, and remove any?
  • [N/A] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@jessicarowell jessicarowell self-assigned this Sep 20, 2025
@jessicarowell jessicarowell merged commit daf5ff9 into dev Sep 20, 2025
2 checks passed
@jessicarowell jessicarowell deleted the genbank-fix branch September 20, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant