Skip to content

Remove the accidental 'def' in main.nf Channel initialization#355

Merged
jessicarowell merged 1 commit intodevfrom
354-simple-test-fails
Sep 19, 2025
Merged

Remove the accidental 'def' in main.nf Channel initialization#355
jessicarowell merged 1 commit intodevfrom
354-simple-test-fails

Conversation

@jessicarowell
Copy link
Collaborator

Description

I had accidentally created a function (line 60 of main.nf), which caused a scoping conflict as Nextflow interpreted that I was redefining Channel. Removing 'def' fixes this issue. I'm not sure why it never caused an issue on my system, but that meant I didn't catch it.

def dummy_wait = Channel.value(true) -> dummy_wait = Channel.value(true)

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • [N/A] Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • [N/A] Did you check for sensitive data, and remove any?
  • [N/A] If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@jessicarowell jessicarowell self-assigned this Sep 19, 2025
@jessicarowell jessicarowell linked an issue Sep 19, 2025 that may be closed by this pull request
@jessicarowell jessicarowell changed the base branch from master to dev September 19, 2025 03:42
@jessicarowell jessicarowell merged commit 81c0768 into dev Sep 19, 2025
0 of 2 checks passed
@jessicarowell jessicarowell deleted the 354-simple-test-fails branch September 20, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple test fails

1 participant