Skip to content

Conversation

@markccchiang
Copy link
Collaborator

Description

This PR addresses an issue in the channel map test, where the y value of the raster tile data received from the backend occasionally fluctuates between 0 and 2. The underlying cause is still uncertain, but it may be related to how the backend interprets the tile request parameters sent from the frontend, resulting in variations during its internal calculations.

Checklist

For the pull request:

  • The Document unchange / Need update the Document

Copy link
Contributor

@pshnghng0318 pshnghng0318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Ok. Now async tiles allows tiles[0].y to be 0, 1, or 2 in the test.

@pshnghng0318
Copy link
Contributor

If the order of the tiles is not 0, 1, 2, ..., the test may need to increase more tiles to check all the tiles are correctly received, not just checking the order of the first tile

@markccchiang
Copy link
Collaborator Author

If the order of the tiles is not 0, 1, 2, ..., the test may need to increase more tiles to check all the tiles are correctly received, not just checking the order of the first tile

I have modified the code and added checks for all tile data in the channel map messages received from the backend. The updated tests passed all GitHub workflow checks without issues, so I will merge the changes into the dev branch.

@markccchiang markccchiang merged commit 55fa23b into dev Dec 18, 2025
261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants