-
Notifications
You must be signed in to change notification settings - Fork 9
Feature tenacity retry logic #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature tenacity retry logic #112
Conversation
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
🧹 Nitpick comments (1)
.github/workflows/generate-pystubs.yml (1)
35-41: Commit strategy may fail silently if no stubs are generated.The current commit logic echoes "No changes to commit" if
git commitfails, but doesn't verify whetherstubgenactually generated stubs. If the workflow fails early, this could mask issues. Consider adding error handling to ensure stubs were actually generated.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
.github/workflows/generate-pystubs.yml(1 hunks).idea/.gitignore(1 hunks).idea/inspectionProfiles/profiles_settings.xml(1 hunks).idea/misc.xml(1 hunks).idea/modules.xml(1 hunks).idea/mpesakit.iml(1 hunks).idea/vcs.xml(1 hunks)mpesakit/retry/__init__.py(1 hunks)mpesakit/retry/retry.py(1 hunks)pyproject.toml(1 hunks)tests/integration/retry/retry.py(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/integration/retry/retry.py (1)
mpesakit/retry/retry.py (1)
retryable_request(21-45)
🔇 Additional comments (1)
pyproject.toml (1)
49-49: Tenacity dependency added correctly.The version constraint allows for patches and minor updates while requiring a minimum version. Consider adding an upper bound constraint to prevent potential breaking changes in future major versions, though this is optional for stable libraries.
Summary by CodeRabbit
New Features
Chores
Tests