Feat/fetcher retry and repo update #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate repo URL
- Updated GITHUB_RAW_BASE to point to Byte-Barn/gitcraft instead of rafaeljohn9/gitcraft
- Added retry logic with exponential backoff (max 3 attempts) to fetch_content and fetch_json
- Improved error messages to include HTTP status codes and reasons
- Adjusted integration test assertions to match new error message format ("Failed" vs "Request failed")
- Added --no-color option to preview subcommands for gitignore, issue, license, and PR templates - Updated preview functions to accept no_color flag and fall back to plain println! when set - Ensures compatibility with non-ANSI terminals and respects user preference for plain output
…ode . Signed-off-by: rafaeljohn9 <rafaeljohb@gmail.com>
Signed-off-by: rafaeljohn9 <rafaeljohb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces user control over colored output in preview commands across multiple subcommands (
gitignore,issue,pr, andlicense). Specifically:--no-colorCLI flag to all preview subcommands to allow disabling syntax highlighting.--no-coloris used, raw template content is printed without ANSI escape sequences, ensuring clean output in non-ANSI terminals (e.g., legacy Windows consoles) or when piping to files.This change improves compatibility and usability in restricted or automated environments while preserving the enhanced visual experience for interactive users.
Type of Change
How Has This Been Tested?
gitcraft gitignore preview,gitcraft issue preview, etc.) with and without the--no-colorflag:--no-colorprints plain text without escape sequences.Checklist
Additional Context
This change aligns with terminal best practices by respecting user preference for plain output and improving robustness in CI/scripts or legacy terminals. Future work could include auto-detection of terminal color support (e.g., via
NO_COLORenv var), but this explicit flag provides immediate value with minimal complexity.