Skip to content

Fix Terran mech armor research ID issues #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamOgon-one wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix Terran mech armor research ID issues #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40f8987
Fix Terran mech armor research ID issues
SamOgon-one Dec 20, 2025
05b7ab1
Fix hardcoded upgrade IDs for Terran armor research
SamOgon-one Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions sc2/unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,6 +1337,32 @@ def research(
:param queue:
:param can_afford_check:
"""
# Avoid a bug where Terran mech armor research does not start due to an incorrect exact_id from the protobuf.
# Hardcode the correct ID.
if upgrade == UpgradeId.TERRANVEHICLEANDSHIPARMORSLEVEL1:
return self(
AbilityId.ARMORYRESEARCH_TERRANVEHICLEANDSHIPPLATINGLEVEL1,
queue=queue,
subtract_cost=True,
can_afford_check=can_afford_check,
)

if upgrade == UpgradeId.TERRANVEHICLEANDSHIPARMORSLEVEL2:
return self(
AbilityId.ARMORYRESEARCH_TERRANVEHICLEANDSHIPPLATINGLEVEL2,
queue=queue,
subtract_cost=True,
can_afford_check=can_afford_check,
)

if upgrade == UpgradeId.TERRANVEHICLEANDSHIPARMORSLEVEL3:
return self(
AbilityId.ARMORYRESEARCH_TERRANVEHICLEANDSHIPPLATINGLEVEL3,
queue=queue,
subtract_cost=True,
can_afford_check=can_afford_check,
)

return self(
self._bot_object.game_data.upgrades[upgrade.value].research_ability.exact_id,
queue=queue,
Expand Down
Loading