Skip to content

Enhance is_detector to include OBSERVER type #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadspratt wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Enhance is_detector to include OBSERVER type #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7053074
Enhance is_detector to include OBSERVER type
chadspratt Dec 11, 2025
fc925f1
pep8 formatting compliance
chadspratt Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sc2/unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,7 +927,11 @@ def detect_range(self) -> float:
def is_detector(self) -> bool:
"""Checks if the unit is a detector. Has to be completed
in order to detect and Photoncannons also need to be powered."""
return self.is_ready and (self.type_id in IS_DETECTOR or self.type_id == UNIT_PHOTONCANNON and self.is_powered)
return (
self.is_ready
and (self.type_id in IS_DETECTOR or self.type_id == UNIT_PHOTONCANNON and self.is_powered)
or self.type_id == UnitTypeId.OBSERVER
)

@property
def radar_range(self) -> float:
Expand Down
Loading