feature: Add sigrok skill implementation#4
Open
yeyeto2788 wants to merge 2 commits intoBrownFineSecurity:masterfrom
Open
feature: Add sigrok skill implementation#4yeyeto2788 wants to merge 2 commits intoBrownFineSecurity:masterfrom
yeyeto2788 wants to merge 2 commits intoBrownFineSecurity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
Just wanted to contribute a skill that would let the users have the same functionality as with the
logicmsobut with a much cheaper a broader option (in terms of devices)Take into consideration that some common logic was moved into
/skills/commonso there is no duplication of code across the whole repository.I have done some tests locally and it is promising as I did make the test with already (available dumps)[https://github.com/sigrokproject/sigrok-dumps]
Cheers.