fix: Add minus sign character support#16
Open
coinexplain wants to merge 1 commit intoBrandonLWhite:gh-pagesfrom
Open
fix: Add minus sign character support#16coinexplain wants to merge 1 commit intoBrandonLWhite:gh-pagesfrom
coinexplain wants to merge 1 commit intoBrandonLWhite:gh-pagesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Brandon,
This PR fixes an issue where the seven-segment display could not render the minus sign ('-') for negative values, even though the segment code exists.
The
displayValuefunction in thesevenSegDigitwidget returned early because '-' was not present in thec_aNumberSegmentsmap's keys.This change simply adds
'-': 0x00to thec_aNumberSegmentsmap, allowing the existing logic to correctly handle and display the minus sign.Now, passing values like "-05" or "-99" works as expected.
Thanks!