Bugfix/disabled #10
Merged
Bugfix/disabled #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a Disabled parameter to the SimpleMultiselect component to prevent user interaction when the component is disabled. The implementation includes proper state handling to close the dropdown when disabled and prevent toggling actions.
Key changes:
- Added the
disabledHTML attribute to the dropdown button when theDisabledparameter is true - Implemented logic to close the dropdown when the component becomes disabled
- Added a guard in the toggle method to prevent opening when disabled
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SimpleMultiselect.razor | Added disabled attribute to button and logic to close dropdown when disabled |
| DisabledTests.cs | Comprehensive test coverage for disabled functionality scenarios |
| StylingTests.cs | Moved styling-related tests to dedicated file |
| SimpleMultiselectTests.cs | Refactored to use BaseTest and removed moved tests |
| BaseTest.cs | Created base test class with shared setup and helper methods |
| TestValueItem.cs | Extracted test model to separate file |
| TestReferenceItem.cs | Extracted test model to separate file |
| EqualityTests.cs | Moved equality-related tests to dedicated file |
| DisabledDropdown.razor | Added demo page for disabled functionality |
| NavMenu.razor | Added navigation link to the disabled dropdown demo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @bind-SelectedOptions="_selectedItems"/> | ||
| </div> | ||
| <div class="col-4"> | ||
| <button class="btn btn-primary" @onclick="() => _isDisabled = !_isDisabled"> |
There was a problem hiding this comment.
Extra space in '_isDisabled =' - should be single space. Change _isDisabled = to _isDisabled =.
| @code { | ||
| private bool _isDisabled; | ||
|
|
||
| private HashSet<string> _selectedItems = []; |
There was a problem hiding this comment.
Field '_selectedItems' can be 'readonly'.
Suggested change
| private HashSet<string> _selectedItems = []; | |
| private readonly HashSet<string> _selectedItems = []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
Fixes
Disabledparameter not working.