-
-
Notifications
You must be signed in to change notification settings - Fork 173
Repairs OTA Feature #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Repairs OTA Feature #783
Conversation
|
Is it permissible to ask what the problem was and where the certificates came from? |
|
Sure thing. Github was changing to a new CA. So the previous ca certificate that was used caused a validation error. Certificate is the current ca-chain of github.com |
Thanks. Any reason to include two certs? |
|
The other certificate is the so called intermediate ca certiciate. USERTrust RSA Certification Authority [CA] We need CA and Sub-CA (intermediate) to perform a full validation of the Endpoint Certificate (*.github.io) Unencrypted (plain) HTTP is not working anymore. |
|
I have already suggested this elsewhere. Instead of embedding the certificate in the source code and building a new version every time it expires or is changed, it could be stored in the flash file system and read from there. Now would be a good time to make the change. |
|
Implementation detail I would say. Ofc it has advantages if its red from fs, but maintainers needs to update it as a working default anyway. Not everyone using awtrix is a developer or is knowing how to fetch and replace a certificate in fs. It just needs to work :) BTW: the sub ca is expiring in 01.01.2031 so I guess we sill have time. |
This replaces the ca certificate in favor of repairing the ota update feature