[HOSM-699] Fix issue with PayPal payment being creating with a 0.01 amount #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mount When we switched over to use the PayPal SDK the callback for createOrder wasn't being set so it defaults to the fallback version which sends a single penny value to PayPal. Updated the patch to use a proper create order with the values that are passed in through configuration when creating the Braintree drop in. Also the `onAuthorize` callback isn't used by PayPal's SDK and instead it uses the `onApprove` callback which we've duplicated so that the correct method is used.
pdredge
approved these changes
Jul 31, 2025
…nchCommerce/module-checkout into hotfix/paypal-create-order-amount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched over to use the PayPal SDK the callback for createOrder wasn't being set so it defaults to the fallback version which sends a single penny value to PayPal.
Updated the patch to use a proper create order with the values that are passed in through configuration when creating the Braintree drop in.
Also the
onAuthorizecallback isn't used by PayPal's SDK and instead it uses theonApprovecallback which we've duplicated so that the correct method is used.