Skip to content

Conversation

@erannave
Copy link

@erannave erannave commented Apr 28, 2025

User description

Updated all dependencies to the latest versions and made some modifications which were needed to fix breaking changes from the deps


PR Type

  • Enhancement

Description

  • Updated dependencies: React, styled-components, faker.

  • Refactored styled props with "$" prefix consistently.

  • Changed SVG imports to use "?react" query.

  • Removed deprecated ESLint config and added new configuration.


Changes walkthrough 📝

Relevant files
Enhancement
20 files
index.ts
Updated SVG imports to use ?react query                                   
+14/-14 
Calendar
Refactored Grid, Header, and types with $ prefix                 
ConfigPanel
Renamed expansion props to $isExpanded in config panel     
EmptyBox.tsx
Updated SVG import to include ?react parameter                     
+1/-1     
IconButton
Renamed IconButton props to use $ prefix                                 
LeftColumn
Refactored styled props and pagination props with $ prefix
Loader
Updated Loader component to use $position prop                     
PaginationButton
Converted pagination button props to $ prefix usage           
Scheduler
Updated Scheduler component with $ prefixed styled props 
Tiles
Renamed tile bold prop to $bold and adjusted types             
CalendarProvider.tsx
Minor JSX formatting update in provider component               
+2/-1     
appMock.ts
Updated faker usage for random words and date generation 
+11/-8   
global.ts
Renamed variant property to $variant globally                       
+1/-1     
drawRows
Updated bottom row drawing functions with $variant             
getBoxFillStyle.ts
Destructured config using $variant for fill style               
+2/-2     
getTextStyle.ts
Updated text style function to use $variant prop                 
+3/-3     
vite.config.d.ts
Changed Vite config type from UserConfigExport to UserConfig
+1/-2     
ESLint configs
Removed .eslintignore, .eslintrc and added eslint.config.js
package.json
Updated dependencies and bumped version to 0.4.0                 
+33/-33 
vite.config.js
Added comprehensive Vite configuration with new plugins   
+55/-0   
Additional files
34 files
.eslintignore +0/-2     
.eslintrc +0/-72   
eslint.config.js +85/-0   
Grid.tsx +4/-4     
styles.ts +2/-2     
types.ts +1/-1     
Topbar.tsx +5/-4     
types.ts +1/-1     
ConfigPanel.tsx +3/-2     
styles.ts +2/-2     
IconButton.tsx +6/-5     
styles.ts +8/-8     
types.ts +2/-2     
LeftColumn.tsx +5/-5     
LeftColumnItem.tsx +4/-3     
styles.ts +6/-5     
types.ts +2/-2     
styles.ts +1/-1     
types.ts +1/-1     
Loader.tsx +2/-2     
styles.ts +2/-2     
types.ts +1/-1     
PaginationButton.tsx +5/-5     
styles.ts +5/-5     
types.ts +3/-3     
Scheduler.tsx +5/-3     
styles.ts +1/-1     
types.ts +1/-1     
Tile.tsx +3/-2     
styles.ts +1/-1     
types.ts +1/-1     
types.ts +2/-1     
drawDaysOnBottom.ts +1/-1     
drawWeeksOnBottom.ts +1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • dariaFurmaniak and others added 4 commits August 23, 2024 12:53
    …to breaking changes
    
    BREAKING CHANGE: dependencies updated to react 19.1, styled-components 5.1, @faker-js/faker 9.7
    chore: re-added missing changes from origin
    @bitnoise-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Prop Type Consistency

    The new $clickable prop is being set as a string ("true" or "false") rather than using a boolean. Using a boolean type would enhance clarity and consistency with other similar props.

      $clickable={typeof onItemClick === "function" ? "true" : "false"}
      rows={rows}
      onClick={() => onItemClick?.({ id, label: item })}
    >
      <StyledInnerWrapper>

    Naming Convention Consistency
    Major refactoring has introduced new $-prefixed prop names (e.g., $position, $variant, $isFullRounded). It is important to verify that all components, type definitions, and styled files are uniformly updated to prevent any runtime discrepancies.

    @bitnoise-pr-agent
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @erannave erannave changed the title Dependency updates feat: dependency updates Apr 28, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants