Disable DSN default values on macOS#158
Merged
alinaliBQ merged 2 commits intoapache-odbcfrom Feb 25, 2026
Merged
Conversation
justing-bq
reviewed
Feb 24, 2026
| Set(FlightSqlConnection::TRUSTED_CERTS, | ||
| ReadDsnString(dsn, FlightSqlConnection::TRUSTED_CERTS)); | ||
|
|
||
| #ifndef __APPLE__ |
There was a problem hiding this comment.
I think it makes more sense to do the #ifdef APPLE first and let windows and linux be covered by #else rather than the other way around. It is more consistent with the rest of the code.
Author
There was a problem hiding this comment.
Yup good point, I have addressed your comment
alinaliBQ
changed the title
justing-bq
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable DSN default values on maOS. This is because iodbc driver manager on macOS treats default values as real values when reading from system DSN, and the driver manager ignores the actual values.
Raised issue apache#49387 in Arrow community to enable the default values.