Skip to content

fix(scanner): always render video element to avoid race condition #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gaubee merged 1 commit into from
Dec 26, 2025
+10 −3
Merged

fix(scanner): always render video element to avoid race condition #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/pages/scanner/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,16 @@ export function ScannerPage({ onScan, className }: ScannerPageProps) {

{/* Camera viewfinder */}
<div className="relative flex-1">
{(state === 'scanning' || state === 'success') && (
<video ref={videoRef} className="absolute inset-0 size-full object-cover" playsInline muted />
)}
{/* Video 始终渲染，避免 srcObject 设置时元素不存在的 race condition */}
<video
ref={videoRef}
className={cn(
'absolute inset-0 size-full object-cover',
state !== 'scanning' && state !== 'success' && 'invisible'
)}
playsInline
muted
/>

{/* Scan overlay */}
<div className="absolute inset-0 flex items-center justify-center">
Expand Down