-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add PLINK 1.9 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add PLINK 1.9 #301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds PLINK 1.9, a whole-genome association analysis toolset, to BioArchLinux. The package is configured to track releases from the chrchang/plink-ng GitHub repository and builds from source with custom patches.
Key Changes:
- New package configuration for plink1.9 with git-based versioning tracking the plink-ng repository
- PKGBUILD defining build process including preparation, build, and installation steps with custom patching
- Lilac configuration for automated updates from GitHub releases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| BioArchLinux/plink1.9/lilac.yaml | Configures automated package management with GitHub source tracking for version 1.9 releases and post-build git commit automation |
| BioArchLinux/plink1.9/PKGBUILD | Defines package build process including source retrieval, patching, compilation flags, and installation for plink1.9-git package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I will invite you as co maintainer once this pr is merged, though I am on leave |
|
I think it is not version 1.9.x, though it is named plink-1.9. The latest version is v2.0.0-a.6.29, and the PKGBUILD uses plain vcs source with no commit or tag pinned, so it will keep up with the latest commit (version 2.0.0 and later) |
|
@sukanka No, that's a quirk of the repo structure. Both 1.9 and 2.0 live under the same source tree; that's why we use This is how it's handled on AUR; please correct me if its not the same here. |
Oh. I see, there are 1.9 and 2.0 under the same directory. |
|
I believe all comments so far have been resolved. |
|
i think the regex syntax is wrong. [plink]
source = "github"
github = "chrchang/plink-ng"
use_max_tag = "true"
include_regex = "^v1.9"
prefix = "v"running |
|
It should be |
|
Understood; the regex has to match the whole version string, not just a part. I missed that while reading the docs.
That matches one of the |
Involved packages
As previously discussed.
Details