Skip to content

Upgrade examples/react-router to use react-router 1.0-rc1#142

Open
andrewslater wants to merge 2 commits intoBinaryMuse:masterfrom
andrewslater:react-router-1.0
Open

Upgrade examples/react-router to use react-router 1.0-rc1#142
andrewslater wants to merge 2 commits intoBinaryMuse:masterfrom
andrewslater:react-router-1.0

Conversation

@andrewslater
Copy link

Upgrades the react-router example to use react-router 1.0-rc1

Was trying to reproduce the issue I'm seeing as documented in #141 however even after upgrading to react-router 1.0-rc1 I am not able to reproduce the issue where I see

Warning: owner-based and parent-based contexts differ (values: `undefined` vs `[object Object]`) for key (flux) while mounting module.exports (see: http://fb.me/react-context-by-parent)

when injecting fluxxor into my router components in another app I'm working on. Nevertheless this code to migrate to react-router 1.0-rc1 may be useful to the Fluxxor project.

@BinaryMuse
Copy link
Owner

Thanks for this, @andrewslater. I'm going to wait for React Router 1.0 final to hit to update the site and example, but this will be useful for the update.

@nosovsh
Copy link

nosovsh commented Oct 3, 2015

I get the same error after migrating to react-router 1.0.0-rc1

@BinaryMuse
Copy link
Owner

See this comment for an explanation of the context issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants