Open
Conversation
Member
|
@adamkemberling I have let this slipped - sorry! How about changing the "zonal" language to "roi" for region of interest? |
Collaborator
Author
|
I like the roi language much more than the zonal, I can tweak that and then tidy it up for a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the language could be cleaner, but this is how I have been processing zonal summaries. There are a couple steps to follow:
get_poly_mesh_intersection()get_mesh_element_timeseries(), usingget_average_from_nodes()on each element.get_area_weighted_zonal_average()The function
get_timeseries_for_poly()is a wrapper around doing steps 2-4.Each of these need namespace bindings to be added, but I wanted to just contribute something to feel like I've done something.