hearing#160
Closed
caitlink12 wants to merge 3 commits intofeature/v3.0.0-validation-infrastructurefrom
Closed
Conversation
caitlink12
requested review from
DougManuel and
yulric
and removed request for
yulric
Fix 6 issues in PR #160 HUI worksheets: - I1: HUI06 databaseStart typo cchs_2009_2010_m -> cchs2009_2010_m - I2: HUI06 variableStart typo HUAC_06 -> HUIC_06 - I3: HUI09 wrong source variable [HUI_08] -> [HUI_09] - I4: All HUI06-09 rows had underscore typo in database names - I5: HUI07A missing 2005 and 2007-2008 cycles - I6: HUI09 missing 2011-2012 cycle Add CEP-004 documentation with validation showing: - 2003 PUMF has no Ontario data for HUI hearing/vision - HUI 6-point scale vs Washington Group 4-point scale (2017-2018) - Integration testing with rec_with_table() Published: https://dmanuel.quarto.pub/cep-004-hearing-and-vision-variables
Contributor
Summary of reviewHearing variables (from your PR):HUI06, HUI07, HUI07A, HUI08, HUI09 - individual hearing items Vision variables (added):
HUI01, HUI02, HUI03, HUI04, HUI05 - individual vision items Identified and corrected 6 issues in the original PR
Analyses of availability for provinces, with a focus on Ontario older people, to support the study in progress.During validation, we discovered that the 2003 PUMF has NO Ontario data for HUI hearing/vision variables (HUICGHER, HUICGVIS). The 2003 cycle only contains data from Atlantic provinces and Quebec. This is a data collection artefact, not a worksheet error, but it's important for users planning Ontario-based analyses. DocumentationPublished detailed documentation at: This includes:
Next stepsReady for merge. Future iterations may add:
|
DougManuel
approved these changes
Jan 26, 2026
Contributor
DougManuel
left a comment
DougManuel
left a comment
There was a problem hiding this comment.
See comments.
OK to merge after others have reviewed. @rafdoodle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hearing variables HUI06, HUI07, HUI07A, HUI08, and HUI09 were included into variables and variable_details sheets. Master survey cycles for variables HUI06, HUI07, HUI08, and HUI09 master survey cycles include 2001, 2003, 2009-2010, and 2013-2014. For variable HUI07A, the master survey cycles include 2001, 2003, 2009-2010, 2013-2014, and 2017-2018.
Note: for survey cycle 2017-2018, the hearing variables are captured using the Washington Group Measure for disability. As such, the 2017-2018 variable WDM_101 is taken as an equivalent variable to HUI07A captured in previous cycles and harmonized to HUI07A.