Open
Conversation
added cchs 2015-16 and 2017-18 survey cycles for ADL variables and associated functions
added in 2015-2016 and 2017-2018 master survey cycles into ADLs
Contributor
|
@caitlink12 Can you indicate what variables you added, modified, or deleted? I thought these were already previously part of the PR -- this PR started with your changes in the "temp" repo. @yulric Do you have suggestions for reviewing this commit with 100% diffs? |
Contributor
|
@caitlink12 just confirming these variables don't include the derived variables. That was previously submitted by you. Right? |
yulric
changed the base branch from
feature/v3.0.0-validation-infrastructure
to
adj-bmi
yulric
requested changes
Nov 10, 2025
Contributor
yulric
left a comment
yulric
left a comment
There was a problem hiding this comment.
There are inconsistencies with the suffixes used between the variables and variable details sheet. The variables sheet uses _m whereas the details sheet uses _i. Can you fix those?
fixed the name of incorrect survey variables used for 2017-2018 survey cycles
yulric
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2015-2016 and 2017-2018 master files cycles added to ADL_01, ADL_02, ADL_03, ADL_04, ADL_05, ADL_06 in variable_details
2015-2016 and 2017-2018 master file cycles added to ADL_01-ADL_06 in variables.csv
Note: ADL module not completed in Ontario for 2015-2016 and 2017-2018 but was completed in other provinces. Therefore, for completeness, these master survey cycles were still included.