Conversation
I created three PRS records for the scribe and two owners of ANLcr42. I update PRS6876Matewos, because one link in floruit was inconsistent.
CarstenHoffmannMarburg
added a commit
to BetaMasaheft/Manuscripts
that referenced
this pull request
Feb 11, 2026
I created a record for ANLcr42 according to our discussion in BetaMasaheft/Documentation#3246. I created a LIT7816Burake in BetaMasaheft/Works#1947 (comment), which is not merged yet presumably because of technical problems. I have suggested two create two more LIT IDs for the texts in ms_i1.8.1 and ms_i1.8.5 (cf. BetaMasaheft/Documentation#3259). I have created PRS IDs for owners and for the scribe in BetaMasaheft/Persons#1316.
MagdaKrzyz
approved these changes
Feb 11, 2026
PRS6001-7000/PRS6876Matewos.xml
Outdated
| Emperor <persName ref="PRS10378Yohanne"/>. | ||
| He was a bishop of <placeName ref="LOC5597Sawa"/> <date notBefore="1881" notAfter="1889">from 1881 to 1889</date>. | ||
| Following the death of Emperor <persName ref="PRS10378Yohanne"/> in 1889, | ||
| when <persName ref="PRS7006Menilek"/> became Emperor he received permission from Coptic patriarch |
Contributor
There was a problem hiding this comment.
the Coptic ...
comma before "he received"
Contributor
Author
There was a problem hiding this comment.
I rephrased it to improve the semantics.
MagdaKrzyz
approved these changes
Feb 11, 2026
| <person sex="1"> | ||
| <persName xml:lang="gez" xml:id="n1">ወልደ፡ ጊዮርጊስ፡</persName> | ||
| <persName xml:lang="gez" type="normalized" corresp="#n1">Walda Giyorgis</persName> | ||
| <floruit notBefore="1900" notAfter="1915">Beginning of the 20th century</floruit> |
Contributor
There was a problem hiding this comment.
you can add occupation: scribe
Contributor
Author
There was a problem hiding this comment.
To the best of my knowledge, we used occupation type="scribe" only for professional scribes, e.g. of a royal scriptorium, what is rarely the case. I remember just recently, that I corrected @e-schwarz in this regard. Possibly @eu-genia can tell us, how to use occupation consistently. I have not found anything about it in the Guidelines.
CarstenHoffmannMarburg
added a commit
to BetaMasaheft/Manuscripts
that referenced
this pull request
Feb 12, 2026
* Create ANLcr42.xml I created a record for ANLcr42 according to our discussion in BetaMasaheft/Documentation#3246. I created a LIT7816Burake in BetaMasaheft/Works#1947 (comment), which is not merged yet presumably because of technical problems. I have suggested two create two more LIT IDs for the texts in ms_i1.8.1 and ms_i1.8.5 (cf. BetaMasaheft/Documentation#3259). I have created PRS IDs for owners and for the scribe in BetaMasaheft/Persons#1316. * Updates according to Magdas review * Added LIT7817Etan; updated ESbma001 * Update comments * Small updates according to Magda remarks (2nd round) * Add Eugenia to change note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created three PRS records for the scribe and two owners of ANLcr42.
I update PRS6876Matewos, because one link in floruit was inconsistent.