Strip version metadata for BepInEx 5 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds5678
suggested changes
Apr 23, 2025
| return (string?)attribute?.ConstructorArguments.Single().Value; | ||
| } | ||
|
|
||
| private static bool IsPreferStripInformationalVersionInfo(GeneratorExecutionContext context) |
There was a problem hiding this comment.
ShouldStripInformationalVersionSuffix is way easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 by checking if BepInEx is in references and the major version is 5, and if so, strips the build metadata from the informational version when setting
version.The reason the informational version is still used is that it matches more closely what was set as the
<Version/>, such as1.0.0stays as1.0.0while the normal version would be1.0.0.0which BepInEx 5 does still like, but we want the version as we exactly set it, and how it has worked.