Skip to content

Conversation

@ohommes
Copy link
Collaborator

@ohommes ohommes commented Jul 9, 2025

This PR contains an initial prototype for the 4.38 release with the new map_airbases overlay and JS fixes for zooming and scroll zoom. The top-level landing page will line to the KTO maps but the plates are not ready. It also contains the basic KTO framework but uses the 4.37 charts and data in many places.

Bug fixes:

  • The zoom fix here will keep the zoom to the center of the view-port like is the case in BMS.
  • The Airport Highlighting drift (due to float calculations) fix with fixed step size for scroll zoom.

Sean Eidemiller and others added 8 commits February 5, 2024 19:45
Map stays roughly centered when zooming in and out.
Fix flicker and better centering

- Scroll compensation on zoom now happening in the same event loop (no flickering).
- Removed vi swap files added accidentally.
- Added .gitignore with vi swap files.

---------

Co-authored-by: Sean Eidemiller <sean.eidemiller@oracle.com>
This patch adds the ability to zoom with the scroll wheel like in BMS.
Also the zoom can now go from 50% to 200% so  greater range with a
default of 100%.

Issue: #5
* Add scroll wheel zoom in and out (#25)

* Map stays roughly centered when zooming in and out.

* Scroll compensation on zoom now happening in the same event loop. (#22)

Fix flicker and better centering

- Scroll compensation on zoom now happening in the same event loop (no flickering).
- Removed vi swap files added accidentally.
- Added .gitignore with vi swap files.

---------

Co-authored-by: Sean Eidemiller <sean.eidemiller@oracle.com>

* Add scroll wheel zoom

This patch adds the ability to zoom with the scroll wheel like in BMS.
Also the zoom can now go from 50% to 200% so  greater range with a
default of 100%.

Issue: #5

---------

Co-authored-by: Sean Eidemiller <sean.eidemiller@oracle.com>
Co-authored-by: MaxWaldorf <tigrou40@hotmail.com>
Co-authored-by: Sean Eidemiller <157770408+rsedevnet@users.noreply.github.com>

* Fix Issue #17 repeated rescaling of image map.

Repeated scaling of image map will after a while make the image map
coordinates diverge from the location of the airport on the map. To fix this
the coordinates of the image map will be cached and used for calculating
the new image map coordinates when scaling is applie.

This patch also now resizes the airport locator circle so it is not a tiny circle
when zoomed to 200%.

---------

Co-authored-by: Sean Eidemiller <sean.eidemiller@oracle.com>
Co-authored-by: MaxWaldorf <tigrou40@hotmail.com>
Co-authored-by: Sean Eidemiller <157770408+rsedevnet@users.noreply.github.com>
New landing page and under construction for 4.38 Maps.
This PR contains an initial prototype for the 4.38 release with the new map_airbases overlay and JS fixes for zooming and scroll zoom. The top-level landing page will line to the KTO maps but the plates are not ready. It also contains the basic KTO framework but uses the 4.37 charts and data in many places.
@ohommes ohommes requested a review from MaxWaldorf July 9, 2025 06:59
@ohommes ohommes self-assigned this Jul 9, 2025
@ohommes ohommes added the enhancement New feature or request label Jul 9, 2025
@ohommes ohommes closed this Jul 9, 2025
@ohommes
Copy link
Collaborator Author

ohommes commented Jul 9, 2025

Why is Git flagging all the changes that must be pushed as conflicting. This is not the way that is support to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants