Persistent Switch/DOF IDs and Export Validation#53
Draft
avan069 wants to merge 10 commits intoBenchmarkSims:mainfrom
Draft
Persistent Switch/DOF IDs and Export Validation#53avan069 wants to merge 10 commits intoBenchmarkSims:mainfrom
avan069 wants to merge 10 commits intoBenchmarkSims:mainfrom
Conversation
- Fix reference points defaulting to geometric origin of meshes, instead use Blender object Origin. - Enable alpha-sorting via reference point/object origin Fix for 47: BenchmarkSims#47
- Reload option for DOF/switch/callback.xml source files added to add-on preferences dialog. - Clears scene/global context/cache then forces reload, avoids persistent cache blocking xml updates.
- Fix BenchmarkSims#21 - At mesh join, rename active UV layer to "UVMap" if required to prevent data loss - Improve performance in join loop by batching join operation - approx 10% performance increase in scenes heavy with non-mesh nodes, approx 50% in scenes heavy with mesh nodes (not thoroughly tested for actual performance gains, but it's definitely better :) )
- Introduce persistent properties for DOF and Switch numbers/branches - Retain backward compatibility for list indices but new method is invariant to xml updates and allows manual switch/dof value editing similar to MAX plugin - Updates to UI panels: Persistent IDs for DOF, Switch/Branch, and auto assignment options for current/collection/scene to set those properties (as plugin operators.) Displays (Switch:Branch) in both UI panel list and object name to quickly identify branches.
Attempt to strengthen handling of UV maps in join operations, particularly use names to avoid stale reference
Filter box now permits filtering by DOF or switch number. For a switch, appending ":" will show all branches for the preceeding switch number. You can still search by name. Creates filter_items() methods for both SwitchList and DofList.
68c1312 to
dbc8bc3
Compare
- Implement extensible system for validating a scene at point of export (or whenever) - export_validation.py - Validation pipeline with ExportValidator performing analysis to detect common issues. Returns ValidationIssue (dataclass) objects containing type classification and list of affected objects for resolution - validation_dialogs.py - Dialog operators to guide user through contextual resolution options (eg. execute a batch operation, select issue objects and quit, ignore) Still working on UI and edge cases
- Add common/resolve_ids.py with helpers for resolving DOF and Switch persistent IDs - Replace direct list index access throughout. Refactors dof_editor.py, dof_input_node.py, util.py, and dof_behaviour.py - Prevent IndexError and stale data
- Hydrate DOF/switch lists, prioritizing scene-cached data over disk XML - New preferences to control list reload behavior and warnings. - Updates all usages to prefer persistent IDs, and improves validation/migration dialogs - Refactor related operators/helpers Known: - Still does not entirely guard against switch/dof xml discrepancies if user reloads - some responsibility on user to reload XMLs with "more"/"improved" information - UIList (dof/switch panel) still display incorrect item if cached list is incomplete - should rely on PID first and deselect the list
Author
|
Significantly improved consistency of usage and hardened against edge cases. Node system still in-work though, evaluating potential effects there. (Should be minimal for now - just switch/dof # resolutions) In work: incremental UX improvements, validation modes and associated UI, logging scheme and UI, efficiency. Note for documentation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persistent IDs (PIDs)
Universality
UI dressing for usability
Export Validation
Why it's needed