Bug/#49 bounding box error#50
Merged
tumbler31 merged 18 commits intoBenchmarkSims:mainfrom Jun 6, 2025
Merged
Conversation
…ing box operations.
…o be common to the required bbox transformation.
…t and parent.dat. Added some inline explaination of Dimension numbers to parent.dat file output.
…f 13 seemed arbitrary and unenforced given that A10 model already has 15 slots.
…x-bugs Bug/BenchmarkSims#36 bounding box bugs
…ng-issue BenchmarkSims#39. Updated slot logic, range from 0 -> 20. Hardlimit of 13 seemed a…
BenchmarkSims#35. Applied max+1 fix to switches.
…ned-to-bbox BenchmarkSims#41. Prevent Bounding boxes being considered for material merging.
tumbler31
reviewed
Jun 5, 2025
Contributor
Author
|
Tested working fine in the editor
…On Fri, 6 Jun 2025 at 7:58 am, tumbler31 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bms_blender_plugin/exporter/bml_output.py
<#50 (comment)>
:
> """
- bounding_box_1_min_coords = BBox_Array[0].min_bms_vertex
- bounding_box_1_max_coords = BBox_Array[0].max_bms_vertex
+ if len(BBox_Array) > 0:
+ bounding_box_1_min_coords = BBox_Array[0].min_bms_vertex
+ bounding_box_1_max_coords = BBox_Array[0].max_bms_vertex
+ else:
+ print("Model does not define a bounding box. Reverting to zero-size box.")
can the editor handle a zero sized bbox or will it crash?
—
Reply to this email directly, view it on GitHub
<#50 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLAT45ZMNLYHUKG5LUSVHKD3CC4Q7AVCNFSM6AAAAAB6VEP3QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMBSGU4DENZVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
tumbler31
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some basic error handling to avoid export failure where a bounding box is not defined.
Tested ok on simple cube export.