This repository was archived by the owner on Oct 10, 2018. It is now read-only.
Open
Conversation
testDone is scheduled every 500ms, but the termination check is counter === number, so, there is high possibility that after every 500ms, the counter is bigger than number, then testDone will go to deadloop. Another issue is socket.io does not support to specify a custom timeout value, the default value is 20000ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There will be a dead loop if monitor.counter is larger than expected number in each process. This happens frequently because testDone was scheduled every 500ms and it will check whether monitor.counter == number.
This fix records "expectCounter" in monitor itself, so when the expectCounter is equal to counter, monitor will stop increase counter and it also notify the worker through callback. This can avoid the dead loop.
In addition, allow users to specify a customized timeout.