-
Notifications
You must be signed in to change notification settings - Fork 97
Closes #4096, adding range parameter to histogram functions
#4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d351696 to
d51dafd
Compare
b281dc9 to
36a920c
Compare
range parameter to histogram functionsrange parameter to histogram functions
d541bf8 to
8fd9a7d
Compare
range parameter to histogram functionsrange parameter to histogram functions
198d1c3 to
30a9c22
Compare
30a9c22 to
ee02655
Compare
|
Thank you @jaketrookman for the approval. I am working to implement the last open item for this PR, which is to use |
7caf3b4 to
ebbc182
Compare
|
@ajpotts or @jaketrookman - I have made all the changed I wanted to. Could you please review? These are in the last two commits. I will rebase everything down to a single commit before merging. |
|
Looks good other than the accidental changes to |
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
0ccdd52 to
5caa0ba
Compare
|
FYI: I just closed and re-opened to restart the CI checks. The failure reported previously, due to failed fetch of https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz, seems transient. |
Closes #4096. Required by Bears-R-Us/arkouda-contrib#179
Adds
numpy-style optionalrangeparameter to client histogram functions:histogram()histogram2d()histogramdd()Switches the histograms produced by
histogramdd()to containfloatcounts instead of integer counts, to matchnumpy.While there:
histogramdDMsg()more efficient.histogramdd()oncumprod()./and trailing whitespace.