Skip to content

Conversation

@vasslitvinov
Copy link
Contributor

@vasslitvinov vasslitvinov commented Feb 5, 2025

Closes #4096. Required by Bears-R-Us/arkouda-contrib#179

Adds numpy-style optional range parameter to client histogram functions:

  • histogram()
  • histogram2d()
  • histogramdd()

Switches the histograms produced by histogramdd() to contain float counts instead of integer counts, to match numpy.

While there:

  • Makes histogramdDMsg() more efficient.
  • Factors out some histogram server code.
  • Removes the dependence of histogramdd() on cumprod().
  • Cleans up Makefile to remove an extraneous / and trailing whitespace.

@vasslitvinov vasslitvinov added the numpy alignment Align Arkouda API to the Numpy API label Feb 12, 2025
@vasslitvinov vasslitvinov changed the title Add range parameter to histogram functions Closes-4096, adding range parameter to histogram functions Feb 12, 2025
@vasslitvinov vasslitvinov force-pushed the histogram-ranges branch 2 times, most recently from d541bf8 to 8fd9a7d Compare February 13, 2025 00:17
@vasslitvinov vasslitvinov changed the title Closes-4096, adding range parameter to histogram functions Closes #4096, adding range parameter to histogram functions Feb 13, 2025
@ajpotts ajpotts requested a review from e-kayrakli February 14, 2025 20:25
@vasslitvinov
Copy link
Contributor Author

Thank you @jaketrookman for the approval. I am working to implement the last open item for this PR, which is to use float when passing the range parameter to Chapel in all cases, even when operating on integer data. This is to implement numpy-like behavior. I will ping you once it is ready.

@vasslitvinov
Copy link
Contributor Author

@ajpotts or @jaketrookman - I have made all the changed I wanted to. Could you please review? These are in the last two commits.

I will rebase everything down to a single commit before merging.

@ajpotts
Copy link
Contributor

ajpotts commented Apr 22, 2025

Looks good other than the accidental changes to registration-config.json.

Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
@vasslitvinov
Copy link
Contributor Author

FYI: I just closed and re-opened to restart the CI checks. The failure reported previously, due to failed fetch of https://sourceware.org/pub/bzip2/bzip2-1.0.8.tar.gz, seems transient.

@ajpotts ajpotts enabled auto-merge April 23, 2025 03:14
@ajpotts ajpotts added this pull request to the merge queue Apr 23, 2025
Merged via the queue into Bears-R-Us:master with commit 14f81b0 Apr 23, 2025
47 of 48 checks passed
@vasslitvinov vasslitvinov deleted the histogram-ranges branch April 23, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

numpy alignment Align Arkouda API to the Numpy API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add range parameter to histogram functions

4 participants