This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Thread safety and stop messages returning to pool too early#405
Open
zaddo67 wants to merge 2 commits intoBeardedManStudios:alloyfrom
Open
Thread safety and stop messages returning to pool too early#405zaddo67 wants to merge 2 commits intoBeardedManStudios:alloyfrom
zaddo67 wants to merge 2 commits intoBeardedManStudios:alloyfrom
Conversation
…d messages and repeater lists. - Make MessagePoolMulti thread safe as it is called from alloy networking thread and main thread - Make BMSBytePool thread safe - Two of the SendReliableMessage methods were not sending reliably - ForgeUDPSocketServerFacade ChallengeSuccess assumed challenged players still exists in list. Changed to check entry exists. (Might be an issue unique to my project, ok to ignore unless you have same issue) - Helper method in ForgeMessageCodes to instantiate message from message type (Can be ignored) - Helper Method in IPlayerRepository to check if player signature exists (Can be ignored)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that these changes have not been tested outside of my project. So use appropriate caution if you grab them.