This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Fix generic lerp never reaching target#388
Open
NoTuxNoBux wants to merge 1 commit intoBeardedManStudios:developfrom
Open
Fix generic lerp never reaching target#388NoTuxNoBux wants to merge 1 commit intoBeardedManStudios:developfrom
NoTuxNoBux wants to merge 1 commit intoBeardedManStudios:developfrom
Conversation
This will not pose a problem in practice most of the time, because float and double have specific overrides that do work. The generic implementation however always returned a0, which means that the promise of a1 being returned when t = 1 never holds true. If lerping is not supported for a type, the generic implementation should probably always return a1 instead, unless t = 0, immediately reaching the destination. Otherwise, interpolating values gradually over the network will keep trying to get closer to the destination value in YourGeneratedNetworkObject.InterpolateUpdate, but will never reach its destination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384. See also that ticket for context.