Tidy Vue templates and linting config #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add eslint-plugin-vue; wrap console.error calls with DEV checks. Fix template formatting and attribute ordering (v-if/v-for/key placement, self-closing tags), and adjust some prop/type defaults to satisfy lint rules and prevent runtime issues.
Code reviewCommit Message Format IssueThe first commit in this PR does not follow the Conventional Commits specification required by AGENTS.md. Current commit message: Issue: Missing type prefix and not using standard imperative verb. Should be something like: or The other commits in this PR correctly follow the format:
Consider amending the first commit message to follow the Conventional Commits format before merging. Other findings:
|
Use @Stylistic ESLint plugin to enforce formatting instead of Prettier. Remove .prettierrc.json and Prettier deps/scripts, and update eslint.config.js, package.json, package-lock.json, and AGENTS.md.
Update package.json and package-lock.json for multiple dev dependencies (oxlint, @types/node, @typescript-eslint, eslint plugins, vite, sass, vue-tsc). Apply minor whitespace and template fixes in App.vue and main.ts.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint-plugin-vue; wrap console.error calls with DEV checks. Fix template formatting and attribute ordering (v-if/v-for/key placement, self-closing tags), and adjust some prop/type defaults to satisfy lint rules and prevent runtime issues.