-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add Discogs and Wikipedia/Wikidata support #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Implemented ArtistSocialLinks.vue to display social media links for artists. - Integrated social link fetching from Wikidata and Discogs. - Added styles for social link icons and hover effects. - Ensured deduplication of social links from different sources.
…used code; enhance URL extraction in social links
…dering; update styles for better presentation
- Updated the glyph list in demo.html to reflect the correct count and changed the YouTube icon reference. - Modified the CSS styles for the YouTube icon to match the new naming convention. - Removed the ArtistSocialLinks component and integrated social link functionality directly into ArtistLinks.vue. - Enhanced the ArtistProfile.vue to display the first sentence of the profile with a "more" button for additional content. - Updated the logic for extracting and displaying social links from Wikidata and Discogs. - Adjusted styles for better layout and visibility of social links and profile content.
…; enhance first sentence extraction logic
…; initialize active tab state
…ponents for fallback biography display
…improve structure for discography and info sections
…tate management and UI components
…eSelect component for improved usability and maintainability
…st details display and external links
…d former members display
…lingual exclusion sections in Wikidata helper
…der height management
…nd URLs based on floating prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive third-party music database integration to Beardify's artist pages, enabling rich biographical content and external links through Wikidata, Wikipedia, MusicBrainz, and Discogs APIs.
Key Changes:
- Implemented Wikidata/Wikipedia integration for artist biographies with multi-language support
- Added MusicBrainz API integration to link artists to Discogs profiles
- Integrated Discogs API for band member information and additional artist details
- Created new "Info" tab on artist pages with sidebar displaying details, members, and external links
Reviewed changes
Copilot reviewed 22 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/helpers/wikidata.ts |
Wikidata/Wikipedia API client with entity fetching, SPARQL queries, and content cleaning |
src/helpers/musicbrainz.ts |
MusicBrainz API client for artist lookups and Discogs ID resolution |
src/helpers/discogs.ts |
Discogs API client for artist profile data |
src/views/artist/ArtistStore.ts |
Added state and actions for fetching/managing Discogs, Wikidata, and Wikipedia data |
src/components/artist/ArtistInfo.vue |
Main info tab component with Wikipedia/Discogs content display and language switching |
src/components/artist/ArtistSidebar.vue |
Sidebar showing artist details, band members, and external links |
src/components/artist/ArtistProfile.vue |
Discogs profile summary with expandable full biography |
src/components/artist/ArtistTabs.vue |
Tab navigation component for Discography/Info tabs |
src/components/ui/LanguageSelect.vue |
Custom select for Wikipedia language switching |
src/components/ui/CustomSelect.vue |
Generic custom select component |
src/components/artist/ArtistLinks.vue |
Enhanced with social media links from Wikidata/Discogs |
src/components/artist/ArtistHeader.vue |
Integrated tabs and profile display |
src/components/artist/ArtistPage.vue |
Added tab-based content switching with transitions |
src/@types/Artist.ts |
Added TypeScript interfaces for Discogs, Wikidata, and Wikipedia data |
vite.config.ts |
Added security headers for development server |
public/icons/* |
Updated icon font with new social media icons |
|
@BeardedBear I've opened a new pull request, #181, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@BeardedBear I've opened a new pull request, #182, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@BeardedBear I've opened a new pull request, #183, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@BeardedBear I've opened a new pull request, #184, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@BeardedBear I've opened a new pull request, #185, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: BeardedBear <7188702+BeardedBear@users.noreply.github.com>
Co-authored-by: BeardedBear <7188702+BeardedBear@users.noreply.github.com>
Co-authored-by: BeardedBear <7188702+BeardedBear@users.noreply.github.com>
Extract duplicated Discogs markup parsing to shared helper
Add URL validation and DOMPurify sanitization to Discogs markup parser
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…ation functions in ArtistProfile.vue
No description provided.