Skip to content

Updated for 1.9.1#3

Open
sqparadox wants to merge 12 commits intoBattletechModders:masterfrom
sqparadox:master
Open

Updated for 1.9.1#3
sqparadox wants to merge 12 commits intoBattletechModders:masterfrom
sqparadox:master

Conversation

@sqparadox
Copy link

-Collapsed classes into single file and remove unused classes/files
-Updated mod.json and added conflict with MechAffinity (they can work together if perks are disabled for mechaffinity so that it's prefixes don't run)
-Changed both SGCaptainsQuartersStatusScreen_RefreshData and SimGameState_GetExpenditures from Postfixes to Prefixes both of which duplicate the functionality of the original method and also prevent it from being called
-Special thanks to wmtorode as this is essentially the same methodology used in MechAffinity (which I only realized after I came to the conclusion that it's the only to avoid all of those weird finances screen issues when changing spending level)

sqparadox added 12 commits June 9, 2019 21:55
Fixed Load issue with Modtek/Harmony due to multiple instances of the GetExpenditures() method.
Updated for 1.9.1
-Collapsed classes into single file and remove unused classes/files
-Updated mod.json and added conflict with MechAffinity (they can work together if perks are disabled for mechaffinity so that it's prefixes don't run)
-Changed both SGCaptainsQuartersStatusScreen_RefreshData and SimGameState_GetExpenditures from Postfixes to Prefixes both of which duplicate the functionality of the original method and also prevent it from being called
-Special thanks to wmtorode as this is essentially the same methodology used in MechAffinity (which I only realized after I came to the conclusion that it's the only to avoid all of those weird finances screen issues when changing spending level)
-Changed Prefixes to Postfixes so that this will play nicely with other mods that modify monthly expenses (unless they modify monthly mech cost but that would make this mod redundant anyway)

-The SGCaptainsQuartersStatusScreen RefreshData postfix works by using a reimplemented version of ClearListLineItems()
-As Line Items are removed they are checked to see if they are a mech
-If it's not a mech, the key and value are added to the new SectionOneExpenses keyValuePairList thus preserving any values set by a preceding mod's Prefixes or Postfixes

-The SimGameState GetExpenditures PostFix is much simpler
-For each mech, it subtracts finances.MechCostPerQuarter from the incoming return value before adding the modified cost of the mech
@sqparadox
Copy link
Author

-Changed Prefixes to Postfixes so that this will play nicely with other mods that modify monthly expenses (unless they modify monthly mech cost but that would make this mod redundant anyway)

-The SGCaptainsQuartersStatusScreen RefreshData postfix works by using a reimplemented version of ClearListLineItems()
-As Line Items are removed they are checked to see if they are a mech
-If it's not a mech, the key and value are added to the new SectionOneExpenses keyValuePairList thus preserving any values set by a preceding mod's Prefixes or Postfixes

-The SimGameState GetExpenditures PostFix is much simpler
-For each mech, it subtracts finances.MechCostPerQuarter from the incoming return value before adding the modified cost of the mech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments