Open
Conversation
Fixed Load issue with Modtek/Harmony due to multiple instances of the GetExpenditures() method.
Updated for 1.9.1 -Collapsed classes into single file and remove unused classes/files -Updated mod.json and added conflict with MechAffinity (they can work together if perks are disabled for mechaffinity so that it's prefixes don't run) -Changed both SGCaptainsQuartersStatusScreen_RefreshData and SimGameState_GetExpenditures from Postfixes to Prefixes both of which duplicate the functionality of the original method and also prevent it from being called -Special thanks to wmtorode as this is essentially the same methodology used in MechAffinity (which I only realized after I came to the conclusion that it's the only to avoid all of those weird finances screen issues when changing spending level)
-Changed Prefixes to Postfixes so that this will play nicely with other mods that modify monthly expenses (unless they modify monthly mech cost but that would make this mod redundant anyway) -The SGCaptainsQuartersStatusScreen RefreshData postfix works by using a reimplemented version of ClearListLineItems() -As Line Items are removed they are checked to see if they are a mech -If it's not a mech, the key and value are added to the new SectionOneExpenses keyValuePairList thus preserving any values set by a preceding mod's Prefixes or Postfixes -The SimGameState GetExpenditures PostFix is much simpler -For each mech, it subtracts finances.MechCostPerQuarter from the incoming return value before adding the modified cost of the mech
Author
|
-Changed Prefixes to Postfixes so that this will play nicely with other mods that modify monthly expenses (unless they modify monthly mech cost but that would make this mod redundant anyway) -The SGCaptainsQuartersStatusScreen RefreshData postfix works by using a reimplemented version of ClearListLineItems() -The SimGameState GetExpenditures PostFix is much simpler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Collapsed classes into single file and remove unused classes/files
-Updated mod.json and added conflict with MechAffinity (they can work together if perks are disabled for mechaffinity so that it's prefixes don't run)
-Changed both SGCaptainsQuartersStatusScreen_RefreshData and SimGameState_GetExpenditures from Postfixes to Prefixes both of which duplicate the functionality of the original method and also prevent it from being called
-Special thanks to wmtorode as this is essentially the same methodology used in MechAffinity (which I only realized after I came to the conclusion that it's the only to avoid all of those weird finances screen issues when changing spending level)