Skip to content

Conversation

@smian1
Copy link
Collaborator

@smian1 smian1 commented Dec 31, 2025

Summary

Changes

  • Added speaker_name: Optional[str] to SimpleTranscriptSegment model
  • Added _add_speaker_names_to_segments() helper (same logic as developer.py)
  • Called in GET /v1/mcp/conversations/{conversation_id} endpoint

Adds speaker_name field to transcript segments in MCP API response,
matching the developer API behavior from BasedHardware#3962.
Copilot AI review requested due to automatic review settings December 31, 2025 04:40
@smian1 smian1 requested a review from mdmohsin7 December 31, 2025 04:41
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the speaker_name field to the transcript segments in the MCP API response, aligning it with the developer API. The implementation is clear and correctly adds the new field to the SimpleTranscriptSegment model and includes a helper function, _add_speaker_names_to_segments, to populate it. The logic for resolving speaker names seems robust. However, I've identified a significant maintainability issue regarding code duplication that should be addressed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds speaker name information to transcript segments in the MCP conversation endpoint, matching the existing functionality from the developer API (PR #3962).

Key Changes:

  • Added speaker_name field to the SimpleTranscriptSegment model
  • Implemented _add_speaker_names_to_segments() helper function to populate speaker names
  • Integrated speaker name enrichment into the conversation detail endpoint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mdmohsin7 mdmohsin7 merged commit c2056d1 into BasedHardware:main Dec 31, 2025
6 checks passed
@smian1 smian1 deleted the feat/mcp-speaker-name branch January 2, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants