Correct VAD and Embedding URL for dev and prod #3990
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the URLs for VAD and Embedding services in the development and production Kubernetes configurations, replacing hardcoded IP addresses with domain names. This is a good improvement for maintainability. However, all the updated URLs use http, which is a critical security risk as it sends data unencrypted. My review includes critical feedback to switch all service URLs to https to ensure secure communication.
| - name: HOSTED_VAD_API_URL | ||
| value: "http://34.172.155.20:80/v1/vad" | ||
| value: "http://vad.omiapi.com:80/v1/vad" | ||
| - name: HOSTED_SPEECH_PROFILE_API_URL | ||
| value: "http://34.172.155.20:80/v1/speaker-identification" | ||
| value: "http://vad.omiapi.com:80/v1/speaker-identification" | ||
| - name: HOSTED_SPEAKER_EMBEDDING_API_URL | ||
| value: "http://34.172.155.20:80" | ||
| value: "http://diarizer.omiapi.com:80" |
There was a problem hiding this comment.
The service URLs are configured to use http, which is insecure as it sends data in plaintext. This can expose sensitive information to network sniffing and man-in-the-middle attacks. It is critical to use https for all API endpoints to ensure data is encrypted in transit. This applies to HOSTED_VAD_API_URL, HOSTED_SPEECH_PROFILE_API_URL, and HOSTED_SPEAKER_EMBEDDING_API_URL.
- name: HOSTED_VAD_API_URL
value: "https://vad.omiapi.com/v1/vad"
- name: HOSTED_SPEECH_PROFILE_API_URL
value: "https://vad.omiapi.com/v1/speaker-identification"
- name: HOSTED_SPEAKER_EMBEDDING_API_URL
value: "https://diarizer.omiapi.com"| - name: HOSTED_VAD_API_URL | ||
| value: "http://172.16.128.101:8080/v1/vad" | ||
| value: "http://vad.omi.me:80/v1/vad" | ||
| - name: HOSTED_SPEECH_PROFILE_API_URL | ||
| value: "http://172.16.128.101:8080/v1/speaker-identification" | ||
| value: "http://vad.omi.me:80/v1/speaker-identification" |
There was a problem hiding this comment.
The service URLs for the production environment are configured to use http. This is a critical security vulnerability as it transmits data without encryption. All production endpoints must use https to protect data integrity and confidentiality. While not part of this change, please note that HOSTED_SPEAKER_EMBEDDING_API_URL on line 110 should also be updated to use https for consistency and security.
- name: HOSTED_VAD_API_URL
value: "https://vad.omi.me/v1/vad"
- name: HOSTED_SPEECH_PROFILE_API_URL
value: "https://vad.omi.me/v1/speaker-identification"| - name: HOSTED_VAD_API_URL | ||
| value: "http://34.172.155.20:80/v1/vad" | ||
| value: "http://vad.omiapi.com:80/v1/vad" | ||
| - name: HOSTED_SPEECH_PROFILE_API_URL | ||
| value: "http://34.172.155.20:80/v1/speaker-identification" | ||
| value: "http://vad.omiapi.com:80/v1/speaker-identification" | ||
| - name: HOSTED_SPEAKER_EMBEDDING_API_URL | ||
| value: "http://34.172.155.20:80" | ||
| value: "http://diarizer.omiapi.com:80" |
There was a problem hiding this comment.
The service URLs are configured with http, which is insecure. All communication should be over https to encrypt the data in transit and prevent potential security breaches. This applies to HOSTED_VAD_API_URL, HOSTED_SPEECH_PROFILE_API_URL, and HOSTED_SPEAKER_EMBEDDING_API_URL.
- name: HOSTED_VAD_API_URL
value: "https://vad.omiapi.com/v1/vad"
- name: HOSTED_SPEECH_PROFILE_API_URL
value: "https://vad.omiapi.com/v1/speaker-identification"
- name: HOSTED_SPEAKER_EMBEDDING_API_URL
value: "https://diarizer.omiapi.com"
|
lgtm @thainguyensunya |
Changes: