fix move wal and backup files to application support dir #3983
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly moves the WAL and backup files from the documents directory to the application support directory within WalFileManager to fix a crash on macOS. This is a good fix. However, the review identified several other places in the codebase, specifically within app/lib/services/wals.dart, where getApplicationDocumentsDirectory() is still being used for similar file operations related to WALs. To fully resolve the issue and ensure consistency, these instances should also be updated to use getApplicationSupportDirectory(). A detailed comment has been added to point out the exact locations.
app/lib/utils/wal_file_manager.dart
Outdated
|
|
||
| static Future<void> init() async { | ||
| final directory = await getApplicationDocumentsDirectory(); | ||
| final directory = await getApplicationSupportDirectory(); |
There was a problem hiding this comment.
This change is correct for WalFileManager. However, the codebase contains other instances of getApplicationDocumentsDirectory() that are also used for managing WAL files and should be updated as well to ensure consistency and fully resolve the issue on macOS.
Specifically, these locations in app/lib/services/wals.dart need to be updated:
Wal.getFilePath(line 212)SDCardWalSync._flushToDisk(line 351)FlashPageWalSync._saveBatchToFile(line 1268)
These methods also handle WAL files and should use getApplicationSupportDirectory() to prevent the same crash. It's recommended to address these in this PR to complete the fix.
|
This happens only on macos right? then I think the right option is to only change it for macos. And also wal doesn't really get used on mac |
Yes, I think this will be good too, I've changed to macos only |
omi/app/lib/utils/wal_file_manager.dart
Line 74 in 81ef150
crash is caused by copying wal file inside the documents dir, and the fix is to move the file to Application Support where macos allows internal write and backup operations
ref: https://stackoverflow.com/questions/66304002/what-is-the-difference-between-getapplicationsupportdirectory-and-getlibrarydire
closes #3940